This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] record.c: make prec can save the execution log to a pic file
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: brobecker at adacore dot com, teawater at gmail dot com, gdb-patches at sourceware dot org
- Date: Thu, 02 Sep 2010 00:55:45 -0400
- Subject: Re: [PATCH] record.c: make prec can save the execution log to a pic file
- References: <AANLkTilO5PKpExEeH53xYI-R3Bm6zWRxNN9MW6SEbGuJ@mail.gmail.com> <4C181DF2.7030604@vmware.com> <AANLkTimQMtNbbCfHK08bRMmovS1wXWSjvL1yAARl-NlJ@mail.gmail.com> <AANLkTikyhrgZhAjgkI_FBE3tvEaV0ybKSYLTv4GV8ZLD@mail.gmail.com> <AANLkTimAH67D1DHWYkS4PYMAGh3rNEad1CCdUJYVSnU1@mail.gmail.com> <AANLkTilqJurquvxC8wM2bAfzAFzHBeKR8G_VddTwlRAo@mail.gmail.com> <20100901231633.GA16396@adacore.com> <4C7EDF79.9050904@vmware.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 01 Sep 2010 16:19:21 -0700
> From: Michael Snyder <msnyder@vmware.com>
> CC: Hui Zhu <teawater@gmail.com>, gdb-patches ml <gdb-patches@sourceware.org>
> > However, I still believe that it is better to back it out for now.
> > First of all, I've already suggested that the code in record.c be
> > at least properly documented, but this never happened. Second of all,
> > I think that the current format used in the nodes titles is inconsistent
> > and makes the resulting graph less useful. What I believe we should do,
> > for this feature, is first go to the drawing board to describe precisely
> > what we want, and only then implement it.
>
> I agree. It needs more discussion.
I will go with whatever you decide. Given the clear description by
Joel of how it works (thanks!), I will be able to rewrite the manual
sections, after a few followup questions. So if the decision is to
keep the patch, I can fix the docs quite quickly.