This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t

From: Joel Brobecker <brobecker at adacore dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: Eli Zaretskii <eliz at gnu dot org>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org
Date: Wed, 1 Sep 2010 12:12:06 -0700
Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
References: <E1Oq55N-0006ia-B0@fencepost.gnu.org> <20100830140814.GE2986@adacore.com> <20100831182829.GA16136@host1.dyn.jankratochvil.net> <20100901181830.GB2986@adacore.com> <20100901182943.GA23673@host1.dyn.jankratochvil.net> <20100901183952.GE2986@adacore.com> <20100901185112.GC24300@host1.dyn.jankratochvil.net>

> Keeping the `enum target_signal' name would contradict (**) the sole
> remaining meaning of the [patch 3/9]#2 patch (*) - making
> target_signal and `int host_signal' type incompatible catching various
> bugs in the current code.

The approach you are suggesting looks fine to me. I thought it would
have been easier to makes changes in the other order, but whichever
you think is best works for me too.

-- 
Joel

References:
- Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
  - From: Joel Brobecker
- Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
  - From: Jan Kratochvil
- Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
  - From: Joel Brobecker
- Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]