This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org
- Date: Tue, 31 Aug 2010 19:03:10 -0700
- Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
- References: <E1Oq55N-0006ia-B0@fencepost.gnu.org> <20100830140814.GE2986@adacore.com> <20100831182829.GA16136@host1.dyn.jankratochvil.net>
> I would prefer gdb_target_signal_t or also gdb_target_signal.
> Is one of those approved?
FWIW: I also prefer gdb_target_signal - Let's avoid _t if POSIX doesn't
like it, and I don't think that the _t brings much anyways.
> Now I probably won't extend target_signal by any new fields (as the logic can
> be kept inside linux-nat.c) so this part remains only as a "code cleanup" to
> better sanity check the types compatibility (by the struct wrapping). There
> have been caught several minor bugs already before and in this patchset.
I will try to have a look at the patch tomorrow, but I agree on
the principle.
--
Joel