This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/commit] include alloca.h if available.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 31 Aug 2010 18:59:44 -0700
- Subject: Re: [RFA/commit] include alloca.h if available.
- References: <1283281511-30193-1-git-send-email-brobecker@adacore.com> <201008312055.40504.pedro@codesourcery.com>
> > On LynxOS, alloca is defined in allocal.h. This fixes one warning that
> > occurs when building GDBserver for LynxOS.
>
> No objections here. One note.
Cool - checked in.
> Every include of malloc.h in gdbserver's common code:
>
> $ grep malloc\\.h *.c
> gdbreplay.c:#include <malloc.h>
> mem-break.c:#include <malloc.h>
> server.c:#include <malloc.h>
> tracepoint.c:#include <malloc.h>
> utils.c:#include <malloc.h>
> win32-low.c:#include <malloc.h>
>
> is there for alloca on mingw32. It might have made
> sense to keep those together. I don't really care that
> much either way, just pointing it out. :-)
If it is just for malloc, it sounds like the include is no longer
necessary? Unless of course malloc.h is the only location where
alloca is defined on mingw32. Either way, since I'm working in
that area of the code, might as well look at it - I think I'm
setup to build the gdbserver on MinGW.
--
Joel