Re: [commit] Build memmem with -Wno-error.

[Pedro Alves <pedro at codesourcery dot com>]

On Tuesday 31 August 2010 21:14:55, Jan Kratochvil wrote:
> On Tue, 31 Aug 2010 21:48:34 +0200, Pedro Alves wrote:
> > It would be better to come up with
> > an $(INTERNAL_CFLAGS) variant that does not include -Werror in the first
> > place, and use that instead in the memmem.o rule.  gdb/Makefile.in uses
> > INTERNAL_WARN_CFLAGS for exactly that.  I suggest to do the same here.  Take
> > a look at the monitor.o rule in gdb/Makefile.in.
> 
> This is a longterm cosmetic problem.  Anytime I modify anything in defs.h VIM
> jumps to the warnings in monitor.c which I have to skip.
> 
> There should be the explicit -Wno-format-nonliteral form.  Just removing
> -Wformat-nonliteral or -Werror is not enough.
> 
> Combined the patch together with making it more restrictive.  It should no
> longer be IMO such a concern since Joel started removing -Werror for releases.
> 
> Tested compilation on x86_64-fedora14snapshot-linux-gnu.

I'm not sure whether this may break the build on older gcc's, but
given --disable-werror, it's fine with me to give this a try.

-- 
Pedro Alves