[patch 6/9]#2 Make linux_get_siginfo_type `type *' unique

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

Hi,

currently gdbarch_get_siginfo_type returns always newly allocated `type *'
which is always the same for the specified gdbarch.

Return always just a single instance for each specific gdbarch.

CHECK_TYPEDEF there is not required, I have just felt it there appropriate.

It would be probably more appropriate more generic, above
gdbarch_get_siginfo_type, I can move it, also changing the caller(s).

It was already leaking for $_siginfo accesses but it would be too severe leak
now.

linux_record_tdep.size_siginfo_t and linux_record_tdep.size_siginfo could be
dropped and replaced by `TYPE_LENGTH (gdbarch_get_siginfo_type (gdbarch))'
now.  Just with all the numerous linux_record_tdep size_* constants it could
be more a maintenance hassle than improvement so I dropped that patch.


Thanks,
Jan


gdb/
2010-08-30  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Make linux_get_siginfo_type `type *' unique.
	* linux-tdep.c (linux_gdbarch_data_handle, struct linux_gdbarch_data)
	(init_linux_gdbarch_data, get_linux_gdbarch_data): New.
	(linux_get_siginfo_type): New variable linux_gdbarch_data.  Initialize
	it.  Use linux_gdbarch_data->siginfo_type as a persistent storage.
	Call also CHECK_TYPEDEF.
	(_initialize_linux_tdep): New.

--- a/gdb/linux-tdep.c
+++ b/gdb/linux-tdep.c
@@ -25,18 +25,42 @@
 #include "elf/common.h"
 #include "inferior.h"
 
+static struct gdbarch_data *linux_gdbarch_data_handle;
+
+struct linux_gdbarch_data
+  {
+    struct type *siginfo_type;
+  };
+
+static void *
+init_linux_gdbarch_data (struct gdbarch *gdbarch)
+{
+  return GDBARCH_OBSTACK_ZALLOC (gdbarch, struct linux_gdbarch_data);
+}
+
+static struct linux_gdbarch_data *
+get_linux_gdbarch_data (struct gdbarch *gdbarch)
+{
+  return gdbarch_data (gdbarch, linux_gdbarch_data_handle);
+}
+
 /* This function is suitable for architectures that don't
    extend/override the standard siginfo structure.  */
 
 struct type *
 linux_get_siginfo_type (struct gdbarch *gdbarch)
 {
+  struct linux_gdbarch_data *linux_gdbarch_data;
   struct type *int_type, *uint_type, *long_type, *void_ptr_type;
   struct type *uid_type, *pid_type;
   struct type *sigval_type, *clock_type;
   struct type *siginfo_type, *sifields_type;
   struct type *type;
 
+  linux_gdbarch_data = get_linux_gdbarch_data (gdbarch);
+  if (linux_gdbarch_data->siginfo_type != NULL)
+    return linux_gdbarch_data->siginfo_type;
+
   int_type = arch_integer_type (gdbarch, gdbarch_int_bit (gdbarch),
 			 	0, "int");
   uint_type = arch_integer_type (gdbarch, gdbarch_int_bit (gdbarch),
@@ -136,6 +160,9 @@ linux_get_siginfo_type (struct gdbarch *gdbarch)
 				       "_sifields", sifields_type,
 				       TYPE_LENGTH (long_type));
 
+  CHECK_TYPEDEF (siginfo_type);
+  linux_gdbarch_data->siginfo_type = siginfo_type;
+
   return siginfo_type;
 }
 
@@ -178,3 +205,10 @@ linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 {
   set_gdbarch_core_pid_to_str (gdbarch, linux_core_pid_to_str);
 }
+
+void
+_initialize_linux_tdep (void)
+{
+  linux_gdbarch_data_handle =
+    gdbarch_data_register_post_init (init_linux_gdbarch_data);
+}