This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC] tracepoint gdbrsp: add -1 introduce for QTFrame:@var{n}


Pedro Alves wrote:
On Sunday 15 August 2010 08:16:34, Hui Zhu wrote:
Sending packet: $QTFrame:ffffffff#fa...Packet received: OK

I think it is a bug that this is assuming 32-bit, two's complement
on both client/server sides. (not sure it that was what you were
referring to).

It's not really assuming that -- it's just assuming that no legitimate frame ID will ever be as high as ffffffff.

That might also be iffy, but less so....


IMO, negatives should have an explicit '-' encoding; in
this case, "$QTFrame:-1".  Note sure if the RSP docs mention something
about this.  We are careful in some cases (passing thread id's,
I think, is one case), though clearly not everywhere.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]