This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix python gdb.execute to not paginate


> Date: Thu, 5 Aug 2010 23:20:08 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: David Malcolm <dmalcolm@redhat.com>
> 
> gdb/doc/
> 2010-08-05  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.texinfo (Mode Options) <-batch>
> 	(Basic Python) <gdb.execute>: Describe setting width and height.

Thanks.

>  command files specified with @samp{-x} (and all commands from
>  initialization files, if not inhibited with @samp{-n}).  Exit with
>  nonzero status if an error occurs in executing the @value{GDBN} commands
> -in the command files.  Batch mode also disables pagination;
> -@pxref{Screen Size} and acts as if @kbd{set confirm off} were in
> -effect (@pxref{Messages/Warnings}).
> +in the command files.  Batch mode also disables pagination, sets unlimited
> +terminal width and height; @pxref{Screen Size} and acts as if @kbd{set confirm
                            ^                    ^
The semi-colon should be removed, and a comma added after @pxref's
closing brace.

> +return value is @code{None}.  With @code{True} @var{to_string} the
> +@value{GDBN} virtual terminal has temporarily set unlimited width and height
> +with disabled pagination; @pxref{Screen Size}.

Suggest to rephrase as follows (assuming I got your intent correctly):

                                    If @var{to_string} is @code{True}, the
  @value{GDBN} virtual terminal will be temporarily set to unlimited width
  and height, and its pagination will be disabled; @pxref{Screen Size}.

Okay with those changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]