This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] create and use symbol_set_language


Hi Pierre,

Thanks for the review :)

   The removal of the 'gsymbol->language == language_cplus'
condition seems to be outside of the scope of the patch you
describe, which seems otherwise quite straightforward.

   Could you please comment on the reason of that specific change?
Is it really part of that patch or shouldn't it be submitted
separately? I must confess that I didn't even try to
look at the source code after the 'if', but just reacted quickly
on something that seem 'off topic' as compared to
your patch description.


I guess Doug has already answered this question. The check for language_cplus was redundant. This should have had a better Changelog entry of course, or been on separate patch :)... I'll fix it


Sami


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]