This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch] gdb_gcore.sh updates
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 23 Jul 2010 19:33:12 +0200
- Subject: [patch] gdb_gcore.sh updates
Hi,
the /dev/null redirection is from an existing Fedora patch.
http://cvs.fedoraproject.org/viewvc/rpms/gdb/devel/gdb-6.6-bz229517-gcore-without-terminal.patch?revision=1.2&content-type=text%2Fplain&view=co
(the testcase there is unreliable for some unknown reasons)
The rest are some obvious changes.
There exists no testcase for this shell script.
Tested the changes by hand on x86_64-fedora13-linux-gnu.
OK to check-in?
Thanks,
Jan
2010-07-23 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb_gcore.sh (tmpfile): Remove the variable, its initialization,
cleanup and generating of gdb script to it.
(gdb): Use redirection from /dev/null. Use --nx. Turn off pagination
and terminal size. Convert $tmpfile to a series of -ex-es.
--- a/gdb/gdb_gcore.sh
+++ b/gdb/gdb_gcore.sh
@@ -45,32 +45,17 @@ then
shift; shift
fi
-# Create a temporary file. Use mktemp if available, but cope if it is not.
-tmpfile=`mktemp ${name}.XXXXXX 2>/dev/null` || {
- tmpfile=${name}.$$
- if test -e $tmpfile; then
- echo "Could not create temporary file $tmpfile"
- exit 1
- fi
- touch $tmpfile
-}
-trap "rm -f $tmpfile" EXIT
-
# Initialise return code.
rc=0
# Loop through pids
for pid in $*
do
- # Write gdb script for pid $pid.
- cat >>$tmpfile <<EOF
-attach $pid
-gcore $name.$pid
-detach
-quit
-EOF
-
- gdb -x $tmpfile -batch
+ # `</dev/null' to avoid touching interactive terminal if it is
+ # available but not accessible as GDB would get stopped on SIGTTIN.
+ gdb </dev/null --nx --batch \
+ -ex "set pagination off" -ex "set height 0" -ex "set width 0" \
+ -ex "attach $pid" -ex "gcore $name.$pid" -ex detach -ex quit
if [ -r $name.$pid ] ; then
rc=0