This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix build failure for win64, revise some format strings


On Fri, Jul 16, 2010 at 10:10 PM, Tom Tromey <tromey@redhat.com> wrote:
> Ozkan> Actually I do: placed_address is CORE_ADDR which is
> Ozkan> bfd_vma, ie. uintptr_t and not a pointer.
>
> Aha. ?I didn't look that deeply.
> There are different functions in utils.c for printing a CORE_ADDR.
>
> Tom
>

That would be core_addr_to_string() I guess (I'm learning), modified
patch attached.  OK to apply?  (Should I use core_addr_to_string_nz
to trim the leading zeroes instead?)

	* target.c (debug_to_insert_breakpoint): Instead of casting to unsigned
	long and %ld, use core_addr_to_string and %s to print CORE_ADDR vars and
	host_address_to_string() and %s for pointers.
	(debug_to_remove_breakpoint): Likewise.
	(debug_to_region_ok_for_hw_watchpoint): Likewise.
	(debug_to_can_accel_watchpoint_condition): Likewise.
	(debug_to_stopped_data_address): Likewise.
	(debug_to_watchpoint_addr_within_range): Likewise.
	(debug_to_insert_hw_breakpoint): Likewise.
	(debug_to_remove_hw_breakpoint): Likewise.
	(debug_to_insert_watchpoint): Likewise.
	(debug_to_remove_watchpoint): Likewise.

--
Ozkan

Attachment: g1a.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]