This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add support for gdb.PYTHONDIR as $gdb_datadir/python.

From: Doug Evans <dje at google dot com>
To: tromey at redhat dot com
Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org
Date: Thu, 24 Jun 2010 12:06:51 -0700
Subject: Re: [PATCH] Add support for gdb.PYTHONDIR as $gdb_datadir/python.
References: <1277403507-29213-1-git-send-email-brobecker@adacore.com> <AANLkTin1M1bztznU1eO6T3aArN4IL70ZFYrwzAyVIph_@mail.gmail.com> <m3ocf06ykd.fsf@fleche.redhat.com>

On Thu, Jun 24, 2010 at 12:05 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> The execfile of __init__.py feels odd. ?I haven't seen it done
> Doug> elsewhere and I wonder if it's needed.
> Doug> [I know python has __init__.py, I just don't know if we have to
> Doug> *explicitly* exec it.]
>
> Normally, no, but in this case we do because the "gdb" module is created
> in C code, not via an import.

If a comment to that effect is added to the code, then I'm happy with
the patch. :-)

References:
- [PATCH] Add support for gdb.PYTHONDIR as $gdb_datadir/python.
  - From: Joel Brobecker
- Re: [PATCH] Add support for gdb.PYTHONDIR as $gdb_datadir/python.
  - From: Doug Evans
- Re: [PATCH] Add support for gdb.PYTHONDIR as $gdb_datadir/python.
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]