This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] testsuite avoid tcl error in gdb.threads/gcore-thread.exp
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Date: Wed, 23 Jun 2010 15:42:11 +0100
- Subject: Re: [RFA] testsuite avoid tcl error in gdb.threads/gcore-thread.exp
- References: <000901cb12dc$40c1f830$c245e890$@muller@ics-cnrs.unistra.fr>
On Wednesday 23 June 2010 14:59:09, Pierre Muller wrote:
> Tested on gcc16 (it works again, hurrah!)
> no changes.
I, and more importantly I guess anyone reading the archives in a
few years, don't know what gcc16 is. I guess it to be a machine in
the gcc compile farm, and I guess it to be running linux, but I don't
know for sure. I don't know if it is x86, x86-64 or something else. Can
you please state x86_64-linux, or something like that instead of
assuming everyone else is using the gcc compile farm?
> OK to commit?
Yes, thanks. I was going to suggest fixing gcore.exp too, but
it was already fixed similarly at some point:
2007-05-14 Markus Deuling <deuling@de.ibm.com>
* gdb.base/gcore.exp: Initialize variable core_supported.
> set escapedfilename [string_to_regexp ${objdir}/${subdir}/gcore.test]
> # Drop corefile
> +global core_supported
> +set core_supported 0
> +
Pedantically, you don't need that "global" statement anymore.
--
Pedro Alves