This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] gdb.base/c*.exp, send_gdb vs. gdb_test
On Sunday 23 May 2010 20:38:48, Michael Snyder wrote:
> >> - send_gdb "call str_func1(s)\n"
> >> - gdb_expect {
> >> - -re "first string arg is: test string.*\"test string\".*$gdb_prompt $" {
> >> - pass "call str_func1(s)"
> >> - }
> >> - -re ".*$gdb_prompt $" { fail "call str_func1(s)" }
> >> - timeout { fail "(timeout) call str_func1(s)" }
> >> - }
> >> + gdb_test "call str_func1(s)" \
> >
> > The previous test output didn't have the extra space. Could you
> > remove it? There are several instances of this.
>
> What extra space are you talking about?
'pass "call str_func1(s)"' vs 'gdb_test "call str_func1(s)"'
^ ^^
Your gdb_test didn't have an explicit message, so the command
string is used as replacement. If gdb.sum diffing didn't reveal
this, I missed something obvious. :-) Anyway, just a nit.
--
Pedro Alves