This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch] psymtab, symfile, symmisc, symtab.c: eliminate unused variables.
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 05 May 2010 18:17:12 -0700
- Subject: [patch] psymtab, symfile, symmisc, symtab.c: eliminate unused variables.
2010-05-05 Michael Snyder <msnyder@vmware.com>
* psymtab.c (lookup_partial_symbol): Delete unused variable.
(find_last_source_symtab_from_partial): Delete unused variable.
* symfile.c (place_section): Delete unused variable.
(default_symfile_offsets): Delete unused variable.
(get_debug_link_info): Delete unused variable.
(find_separate_debug_file_by_debuglink): Delete unused variable.
(add_symbol_file_command): Delete unused variable.
(symfile_find_segment_sections): Delete unused variable.
* symmisc.c (free_symtab): Delete unused variable.
(dump_symtab_1): Delete unused variable.
* symtab.c (lookup_symbil_aux_quick): Delete unused variable.
(find_pc_sect_symtab): Delete unused variable.
(skip_prologue_using_lineinfo): Delete unused variable.
(sources_info): Delete unused variable.
(completion_list_add_name): Delete unused variable.
(expand_line_sal): Delete unused variable.
Index: psymtab.c
===================================================================
RCS file: /cvs/src/src/gdb/psymtab.c,v
retrieving revision 1.2
diff -u -p -r1.2 psymtab.c
--- psymtab.c 10 Mar 2010 18:27:00 -0000 1.2
+++ psymtab.c 6 May 2010 01:09:50 -0000
@@ -427,7 +427,6 @@ struct partial_symbol *
lookup_partial_symbol (struct partial_symtab *pst, const char *name,
int global, domain_enum domain)
{
- struct partial_symbol *temp;
struct partial_symbol **start, **psym;
struct partial_symbol **top, **real_top, **bottom, **center;
int length = (global ? pst->n_global_syms : pst->n_static_syms);
@@ -563,7 +562,6 @@ relocate_psymtabs (struct objfile *objfi
static struct symtab *
find_last_source_symtab_from_partial (struct objfile *ofp)
{
- struct symtab *result;
struct partial_symtab *ps;
struct partial_symtab *cs_pst = 0;
Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.284
diff -u -p -r1.284 symfile.c
--- symfile.c 29 Apr 2010 14:45:38 -0000 1.284
+++ symfile.c 6 May 2010 01:09:50 -0000
@@ -473,7 +473,6 @@ place_section (bfd *abfd, asection *sect
for (cur_sec = abfd->sections; cur_sec != NULL; cur_sec = cur_sec->next)
{
int indx = cur_sec->index;
- CORE_ADDR cur_offset;
/* We don't need to compare against ourself. */
if (cur_sec == sect)
@@ -739,7 +738,6 @@ default_symfile_offsets (struct objfile
struct place_section_arg arg;
bfd *abfd = objfile->obfd;
asection *cur_sec;
- CORE_ADDR lowest = 0;
for (cur_sec = abfd->sections; cur_sec != NULL; cur_sec = cur_sec->next)
/* We do not expect this to happen; just skip this step if the
@@ -1247,7 +1245,6 @@ get_debug_link_info (struct objfile *obj
unsigned long crc32;
char *contents;
int crc_offset;
- unsigned char *p;
sect = bfd_get_section_by_name (objfile->obfd, ".gnu_debuglink");
@@ -1347,12 +1344,10 @@ The directory where separate debug symbo
char *
find_separate_debug_file_by_debuglink (struct objfile *objfile)
{
- asection *sect;
- char *basename, *name_copy, *debugdir;
+ char *basename, *debugdir;
char *dir = NULL;
char *debugfile = NULL;
char *canon_name = NULL;
- bfd_size_type debuglink_size;
unsigned long crc32;
int i;
@@ -2113,7 +2108,6 @@ add_symbol_file_command (char *args, int
char *filename = NULL;
int flags = OBJF_USERLOADED;
char *arg;
- int expecting_option = 0;
int section_index = 0;
int argcnt = 0;
int sec_num = 0;
@@ -3630,7 +3624,6 @@ symfile_find_segment_sections (struct ob
for (i = 0, sect = abfd->sections; sect != NULL; i++, sect = sect->next)
{
- CORE_ADDR vma;
int which = data->segment_info[i];
if (which == 1)
Index: symmisc.c
===================================================================
RCS file: /cvs/src/src/gdb/symmisc.c,v
retrieving revision 1.69
diff -u -p -r1.69 symmisc.c
--- symmisc.c 10 Mar 2010 18:20:07 -0000 1.69
+++ symmisc.c 6 May 2010 01:09:50 -0000
@@ -88,9 +88,6 @@ static int print_symbol (void *);
void
free_symtab (struct symtab *s)
{
- int i, n;
- struct blockvector *bv;
-
switch (s->free_code)
{
case free_nothing:
@@ -322,7 +319,7 @@ dump_symtab_1 (struct objfile *objfile,
struct gdbarch *gdbarch = get_objfile_arch (objfile);
int i;
struct dict_iterator iter;
- int len, blen;
+ int len;
struct linetable *l;
struct blockvector *bv;
struct symbol *sym;
Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.235
diff -u -p -r1.235 symtab.c
--- symtab.c 30 Apr 2010 17:43:55 -0000 1.235
+++ symtab.c 6 May 2010 01:09:50 -0000
@@ -1295,7 +1295,6 @@ lookup_symbol_aux_quick (struct objfile
struct symtab *symtab;
struct blockvector *bv;
const struct block *block;
- struct partial_symtab *ps;
struct symbol *sym;
if (!objfile->sf)
@@ -1661,7 +1660,6 @@ find_pc_sect_symtab (CORE_ADDR pc, struc
struct blockvector *bv;
struct symtab *s = NULL;
struct symtab *best_s = NULL;
- struct partial_symtab *ps;
struct objfile *objfile;
struct program_space *pspace;
CORE_ADDR distance = 0;
@@ -2273,9 +2271,7 @@ skip_prologue_using_lineinfo (CORE_ADDR
{
CORE_ADDR func_start, func_end;
struct linetable *l;
- int ind, i, len;
- int best_lineno = 0;
- CORE_ADDR best_pc = func_addr;
+ int i;
/* Give up if this symbol has no lineinfo table. */
l = LINETABLE (symtab);
@@ -2708,7 +2704,6 @@ static void
sources_info (char *ignore, int from_tty)
{
struct symtab *s;
- struct partial_symtab *ps;
struct objfile *objfile;
int first;
@@ -3367,7 +3362,6 @@ completion_list_add_name (char *symname,
char *text, char *word)
{
int newsize;
- int i;
/* clip symbols that cannot match */
@@ -4175,7 +4169,6 @@ skip_prologue_using_sal (struct gdbarch
if (prologue_sal.symtab->language != language_asm)
{
struct linetable *linetable = LINETABLE (prologue_sal.symtab);
- int exact;
int idx = 0;
/* Skip any earlier lines, and any end-of-sequence marker
@@ -4435,11 +4428,9 @@ append_exact_match_to_sals (char *filena
struct symtabs_and_lines
expand_line_sal (struct symtab_and_line sal)
{
- struct symtabs_and_lines ret, this_line;
+ struct symtabs_and_lines ret;
int i, j;
struct objfile *objfile;
- struct partial_symtab *psymtab;
- struct symtab *symtab;
int lineno;
int deleted = 0;
struct block **blocks = NULL;
@@ -4519,9 +4510,6 @@ expand_line_sal (struct symtab_and_line
blocks = alloca (ret.nelts * sizeof (struct block *));
for (i = 0; i < ret.nelts; ++i)
{
- struct blockvector *bl;
- struct block *b;
-
set_current_program_space (ret.sals[i].pspace);
filter[i] = 1;