This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [ARI] Remove all editCase warnings
- From: Daniel Jacobowitz <dan at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, 'Pedro Alves' <pedro at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Wed, 5 May 2010 14:34:42 -0400
- Subject: Re: [ARI] Remove all editCase warnings
- References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr> <201005050044.28991.pedro@codesourcery.com> <000901caec31$d109e640$731db2c0$@muller@ics-cnrs.unistra.fr> <201005051611.09790.pedro@codesourcery.com> <000001caec6d$59194860$0b4bd920$@muller@ics-cnrs.unistra.fr> <20100505165529.GO2768@adacore.com>
On Wed, May 05, 2010 at 09:55:29AM -0700, Joel Brobecker wrote:
> > static void
> > -ada_remove_Xbn_suffix (const char *encoded, int *len)
> > +ada_remove_Xbn_suffix ( /* ARI: editCase function */
> > + const char *encoded, int *len)
>
> I would rather have:
>
> ada_remove_Xbn_suffix /* ARI: editCase function */
> (const char *encoded, int *len)
>
> This applies to the rest of the patch, where we have the comment
> embedded right in the middle of parameter declaration... For instance:
Frankly, I'd rather we just dropped this ARI rule.
--
Daniel Jacobowitz
CodeSourcery