This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [ARI] Remove all editCase warnings

From: Stan Shebs <stan at codesourcery dot com>
To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
Cc: gdb-patches at sourceware dot org
Date: Tue, 04 May 2010 16:31:54 -0700
Subject: Re: [ARI] Remove all editCase warnings
References: <005b01caebe1$2183b890$648b29b0$@muller@ics-cnrs.unistra.fr>

Pierre Muller wrote:

  	* remote.c (set_remote_protocol_Z_packet_cmd): Rename to...
	(set_remote_protocol_z_packet_cmd): ...this.
	(show_remote_protocol_Z_packet_cmd): Rename to...
	(show_remote_protocol_z_packet_cmd): ...this.
	(store_register_using_P): Rename to...
	(store_register_using_p): ...this.
	(store_register_using_G): Rename to...
	(store_register_using_g): ...this.
	(remote_store_registers): Adapt to name changes above.
	(watchpoint_to_Z_packet): Rename to...
	(watchpoint_to_z_packet): ...this.
	(remote_insert_watchpoint): Adapt to name chage above.
	(remote_remove_watchpoint): Likewise.
	(_initialize_remote): Adapt to name changes above.

Let's make an exception for these, because the upper-case letters in the names refer to specific packets, and for some of these packets there are other packets that use the corresponding lower-case letter. So there is some major confusion potential with this change.

Stan

References:
- [ARI] Remove all editCase warnings
  - From: Pierre Muller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]