This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix crash on NULL rl_prompt

From: Tom Tromey <tromey at redhat dot com>
To: Pedro Alves <pedro at codesourcery dot com>
Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
Date: Tue, 30 Mar 2010 11:30:48 -0600
Subject: Re: [patch] Fix crash on NULL rl_prompt
References: <20100329234026.GA23895@host0.dyn.jankratochvil.net> <201003301741.20844.pedro@codesourcery.com> <20100330170457.GA10938@host0.dyn.jankratochvil.net> <201003301825.18754.pedro@codesourcery.com>
Reply-to: tromey at redhat dot com

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> But isn't `rl_prompt' always built from input feed to readline?

Yes.

Pedro> GDB always gives readline a non-NULL prompt, from what I've seen.
Pedro> Hence, I wouldn't be so fast in calling it correct, but I'm
Pedro> not going to spend more time on this.

I see it as defensive programming.

We can always un-approve it, if you would rather wait to see if a
reproducer is available.

Tom

References:
- [patch] Fix crash on NULL rl_prompt
  - From: Jan Kratochvil
- Re: [patch] Fix crash on NULL rl_prompt
  - From: Pedro Alves
- Re: [patch] Fix crash on NULL rl_prompt
  - From: Jan Kratochvil
- Re: [patch] Fix crash on NULL rl_prompt
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]