This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: update device_error() prototype
- From: Tom Tromey <tromey at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Mike Frysinger <vapier at gentoo dot org>, gdb-patches at sourceware dot org
- Date: Tue, 30 Mar 2010 10:16:25 -0600
- Subject: Re: [PATCH] sim: update device_error() prototype
- References: <1269895146-3394-1-git-send-email-vapier@gentoo.org> <8339zi24r2.fsf@gnu.org>
- Reply-to: tromey at redhat dot com
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>> From: Mike Frysinger <vapier@gentoo.org>
>> Date: Mon, 29 Mar 2010 16:39:06 -0400
>>
>> -void device_error (device *me, char* message, ...);
>> +void device_error (device *me, const char *message, ...) __attribute__((format (printf, 2, 3)));
Eli> Is this always compiled only with GCC? __attribute__ is a GCC
Eli> specific feature, AFAIK.
sim-basics.h defines __attribute__ if not using gcc. This is not really
an approach I would recommend, because different versions of gcc have
different attributes, but it is ok if you stick to a minimal subset of
attributes.
Tom