This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: fix building with system readline
- From: Tom Tromey <tromey at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 22 Mar 2010 11:25:15 -0600
- Subject: Re: [PATCH] gdb: fix building with system readline
- References: <1268964553-30413-1-git-send-email-vapier@gentoo.org>
- Reply-to: tromey at redhat dot com
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> Building gdb with --enable-targets=all and --with-system-readline hits a
Mike> failure in a few targets all related to the inclusion of some opcodes
Mike> headers. The usage of the bundled readline results in an -I to the top
Mike> srcdir, but if that isn't used, then there is no such -I path. A few gdb
Mike> targets use this implicitly to include opcodes/ source header files. So
Mike> change the include paths to use an -I to the opcodes/ directory, and then
Mike> have the gdb files drop the opcodes/ path in the #include.
Mike> An alternative is to add -I$(top_srcdir) to the main CFLAGS ...
I personally find the #include "opcodes/whatever.h" form a little
clearer. However, I don't have very strong feelings about it.
Give this patch a couple more days; if nobody speaks up in favor of one
approach or the other, then it is ok.
thanks,
Tom