This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] remote-mips.c: Don't error out when a memory read fails
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 6 Mar 2010 08:05:35 +0400
- Subject: Re: [RFC] remote-mips.c: Don't error out when a memory read fails
- References: <20100305154846.29fab2c4@redhat.com>
> * remote-mips.c (mips_fetch_word): Add new parameter, `valp'.
> Change return value to int. Store value fetched in location
> addressed by `val'. Use function's return value as success
> or failure indicator. Adjust all callers.
Looks good to me.
> +static int
> +mips_fetch_word (CORE_ADDR addr, unsigned int *valp)
> {
> unsigned int val;
I think that this variable is no longer used?
--
Joel