This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] windows-nat.c: Cygwin: Port to Cygwin 1.7
- From: Roland Schwingel <roland dot schwingel at onevision dot de>
- To: gdb-patches at sourceware dot org
- Date: Mon, 01 Mar 2010 11:04:35 +0100
- Subject: Re: [RFA] windows-nat.c: Cygwin: Port to Cygwin 1.7
Hi Corinna,
I just came along your patch.
gdb-patches-owner@sourceware.org wrote on 28.02.2010 16:08:44:
> Hi,
>
> the below patch ports GDB to the latest Cygwin version 1.7.
...
When I have read that correctly this means gdb would now no longer
compile with cygwin 1.5?
Here I frequently compile gdb head for both cygwin 1.5 and cygwin 1.7.
With your patch this would
no longer be possible.
Wouldn't it be better to encapsulate the 1.5 code and the 1.7 specific
code with
an #if CYGWIN_VERSION_DLL_MAJOR >= 1007 (or something similar).
So on compiletime the proper functions would be selected for the right
cygwin version.
I believe there are for sure more people than me out in this world still
using cygwin 1.5 and wanting
to have a recent gdb...
Roland