This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Generate set_tdesc_osabi for valid OSABI

From: Daniel Jacobowitz <dan at codesourcery dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GDB <gdb-patches at sourceware dot org>
Date: Thu, 4 Feb 2010 12:06:07 -0500
Subject: Re: PATCH: Generate set_tdesc_osabi for valid OSABI
References: <20100204154910.GA2593@lucon.org> <20100204160416.GB14962@caradoc.them.org> <6dc9ffc81002040854h6d88e085x4026d5a8320eeee7@mail.gmail.com>

On Thu, Feb 04, 2010 at 08:54:59AM -0800, H.J. Lu wrote:
> On Thu, Feb 4, 2010 at 8:04 AM, Daniel Jacobowitz <dan@codesourcery.com> wrote:
> > On Thu, Feb 04, 2010 at 07:49:10AM -0800, H.J. Lu wrote:
> >> 2010-02-04 ?H.J. Lu ?<hongjiu.lu@intel.com>
> >>
> >> ? ? ? * target-descriptions.c (maint_print_c_tdesc_cmd): Generate
> >> ? ? ? set_tdesc_osabi for valid OSABI.
> >
> > This patch would require regenerating the board files after changing
> > the enum. ?If we have to hard-code the value, there should be a
> > warning to only add new items to the end of the enum unless
> > regenerating the files.
> >
> 
> Good point. How about using OSABI string instead?

Nice trick.  Yes, this is fine.

-- 
Daniel Jacobowitz
CodeSourcery

References:
- PATCH: Generate set_tdesc_osabi for valid OSABI
  - From: H.J. Lu
- Re: PATCH: Generate set_tdesc_osabi for valid OSABI
  - From: Daniel Jacobowitz
- Re: PATCH: Generate set_tdesc_osabi for valid OSABI
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]