This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Generate set_tdesc_osabi for valid OSABI

On Thu, Feb 4, 2010 at 8:04 AM, Daniel Jacobowitz <dan@codesourcery.com> wrote:
> On Thu, Feb 04, 2010 at 07:49:10AM -0800, H.J. Lu wrote:
>> 2010-02-04 ?H.J. Lu ?<hongjiu.lu@intel.com>
>>
>> ? ? ? * target-descriptions.c (maint_print_c_tdesc_cmd): Generate
>> ? ? ? set_tdesc_osabi for valid OSABI.
>
> This patch would require regenerating the board files after changing
> the enum. ?If we have to hard-code the value, there should be a
> warning to only add new items to the end of the enum unless
> regenerating the files.
>

Good point. How about using OSABI string instead?

Thanks.


-- 
H.J.

Attachment: gdb-tdesc-2.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]