This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Do not disappoint on "Create a core file of GDB?"

From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
To: jan dot kratochvil at redhat dot com
Cc: tromey at redhat dot com, gdb-patches at sourceware dot org
Date: Sat, 30 Jan 2010 14:05:06 +0100 (CET)
Subject: Re: [patch] Do not disappoint on "Create a core file of GDB?"
References: <20100111160241.GA12356@host0.dyn.jankratochvil.net> <m31vhvnttj.fsf@fleche.redhat.com> <20100115003529.GA26561@host0.dyn.jankratochvil.net>

> Date: Fri, 15 Jan 2010 01:35:29 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> On Tue, 12 Jan 2010 17:58:48 +0100, Tom Tromey wrote:
> > Jan> 2010-01-11  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > Jan> 	* configure.ac (AC_CHECK_FUNCS): Check for setrlimit and getrlimit.
> > Jan> 	* configure: Regenerate.
> > Jan> 	* config.in: Regenerate.
> > Jan> 	* utils.c: Include sys/resource.h.
> > Jan> 	(dump_core, can_dump_core): New.
> > Jan> 	(internal_vproblem): Update the comment.  Check can_dump_core while
> > Jan> 	setting dump_core_p.  Replace two abort calls by dump_core calls.
> > 
> > Looks good to me.
> > Ok.
> 
> Checked-in.

I fear that after you did that the "NOTE: GDB has only three calls to
abort()." comment is no longer true.

Can you fix that?

Follow-Ups:
- Re: [patch] Do not disappoint on "Create a core file of GDB?"
  - From: Jan Kratochvil

References:
- [patch] Do not disappoint on "Create a core file of GDB?"
  - From: Jan Kratochvil
- Re: [patch] Do not disappoint on "Create a core file of GDB?"
  - From: Tom Tromey
- Re: [patch] Do not disappoint on "Create a core file of GDB?"
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]