This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Show some tips when file cmd get bfd_error_file_ambiguously_recognized

On Wed, 27 Jan 2010 10:00:34 +0100, Hui Zhu wrote:
> +  ret_len = strlen (bfd_errmsg (error_tag)) + strlen (AMBIGUOUS_MESS1)
> +	    + 50 + strlen (AMBIGUOUS_MESS2);
> +  ret = xmalloc (ret_len + 1);

Rather than all the C strings manipulation fragile magic maybe one could
afford mem_fileopen with ui_file_xstrdup (as being done sometimes in GDB).

Sure it may have been clear and not chosen as very ineffective.


Regards,
Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]