Re: [patch 15/15] PIE: Drop PIE "GDB does NOT currently support"

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Mon, 09 Nov 2009 22:53:43 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> gdb/
> Jan> 	* linux-tdep.c: Remove includes gdbcore.h, observer.h and elf-bfd.h.
> Jan> 	(check_is_pie_binary, _initialize_linux_tdep): Remove.
> Jan> gdb/testsuite/
> Jan> 	* gdb.base/pie-support.exp, gdb.base/pie-support.c: Remove.
> 
> This is ok once the rest of the series is approved.

Checked-in.

+	* gdb.base/pie-support.exp, gdb.base/pie-support.c: Remove.

These files were really removed but cvsweb has some bug so the removal is not
present in the attachment below.

http://sourceware.org/ml/gdb-cvs/2010-01/msg00127.html
->
	http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/Attic/pie-support.c.diff
		Error: src/gdb/testsuite/gdb.base/Attic/pie-support.c.diff: no such file or directory 
	http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/Attic/pie-support.exp.diff
		Error: src/gdb/testsuite/gdb.base/Attic/pie-support.exp.diff: no such file or directory 


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2010-01/msg00127.html

--- src/gdb/ChangeLog	2010/01/14 21:16:51	1.11251
+++ src/gdb/ChangeLog	2010/01/14 21:20:09	1.11252
@@ -1,5 +1,10 @@
 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
+	* linux-tdep.c: Remove includes gdbcore.h, observer.h and elf-bfd.h.
+	(check_is_pie_binary, _initialize_linux_tdep): Remove.
+
+2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
 	* solib-svr4.c (svr4_exec_displacement): New comment for entry_point.
 	Replace exec_entry_point call by bfd_get_start_address.
 
--- src/gdb/linux-tdep.c	2010/01/01 07:31:37	1.6
+++ src/gdb/linux-tdep.c	2010/01/14 21:20:11	1.7
@@ -18,13 +18,10 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdbcore.h"
 #include "gdbtypes.h"
 #include "linux-tdep.h"
-#include "observer.h"
 #include "auxv.h"
 #include "target.h"
-#include "elf-bfd.h"
 #include "elf/common.h"
 
 /* This function is suitable for architectures that don't
@@ -155,33 +152,3 @@
 
   return target_is_uclinux;
 }
-
-/* Observer for the executable_changed event, to check whether the new
-   exec binary is a PIE (Position Independent Executable) specimen, which
-   is currently unsupported.  */
-
-static void
-check_is_pie_binary (void)
-{
-  Elf_Internal_Ehdr *elf_hdr;
-
-  if (!exec_bfd)
-    return;
-  else if (bfd_get_flavour (exec_bfd) != bfd_target_elf_flavour)
-    return;
-
-  if (elf_tdata (exec_bfd)->elf_header->e_type == ET_DYN)
-    warning (_("\
-The current binary is a PIE (Position Independent Executable), which\n\
-GDB does NOT currently support.  Most debugger features will fail if used\n\
-in this session.\n"));
-}
-
-/* Provide a prototype to silence -Wmissing-prototypes.  */
-extern initialize_file_ftype _initialize_linux_tdep;
-
-void
-_initialize_linux_tdep (void)
-{
-  observer_attach_executable_changed (check_is_pie_binary);
-}
--- src/gdb/testsuite/ChangeLog	2010/01/14 21:15:00	1.2088
+++ src/gdb/testsuite/ChangeLog	2010/01/14 21:20:12	1.2089
@@ -1,5 +1,9 @@
 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
+	* gdb.base/pie-support.exp, gdb.base/pie-support.c: Remove.
+
+2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
 	* gdb.base/valgrind-db-attach.exp, gdb.base/valgrind-db-attach.c: New.
 
 2010-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>