This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit/testsuite] Move comment out of gdb_expect code
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 8 Jan 2010 16:07:13 +0400
- Subject: [commit/testsuite] Move comment out of gdb_expect code
This is a change that we have had in our tree for a while. IIRC,
there are no comments in TCL, just the special '#' command that does
nothing. So placing it like this in the middle of the gdb_expect
is not kosher.
I actually see that a similar change was made not too long ago:
2007/10/09 Pierre Muller <muller@ics.u-strasbg.fr>
* lib/gdb.exp (gdb_run_cmd): Move comment outside
of gdb_expect call, to avoid interruption.
gdb/ChangeLog:
* lib/gdb.exp (gdb_start_cmd): Move comment outside of gdb_expect
call, to avoid interruption.
Tested on x86_64-linux. Checked in.
--
Joel
gdb/ChangeLog:
* lib/gdb.exp (gdb_start_cmd): Move comment outside of gdb_expect
call, to avoid interruption.
---
gdb/testsuite/lib/gdb.exp | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 4658c8d..fcaaf3c 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -312,13 +312,13 @@ proc gdb_start_cmd {args} {
}
send_gdb "start $args\n"
+ # Use -notransfer here so that test cases (like chng-sym.exp)
+ # may test for additional start-up messages.
gdb_expect 60 {
-re "The program .* has been started already.*y or n. $" {
send_gdb "y\n"
exp_continue
}
- # Use -notransfer here so that test cases (like chng-sym.exp)
- # may test for additional start-up messages.
-notransfer -re "Starting program: \[^\r\n\]*" {
return 0
}
--
1.6.3.3