This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/doco] Update the "Start of New Year Procedure"


> Date: Fri, 1 Jan 2010 13:10:09 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> I would like to clarify a little bit the process needed to update
> the copyright headers. Patch attached.

Thanks.

> +Run the @code{copyright.sh} script to add the new year in the copyright
> +notices of most source files.  This script requires Emacs 22 or later to
> +be installed.

It's better to put copyright.sh in @file, not in @code.

> +@itemize @bullet
> +  @item @file{*.s}
> +  @item @file{*.f}
> +  @item @file{*.f90}
> +  @item @file{*.igen}
> +  @item @file{*.ac}
> +  @item @file{*.texi}
> +  @item @file{*.texinfo}
> +  @item @file{*.tex}
> +  @item @file{*.defs}
> +  @item @file{*.1}
> +@end itemize

Although this format is permitted, the canonical way of writing an
itemized list is to have @item on its own line:

  @item
  @file{*.s}
  @item
  @file {*.f}
  ...

Did you have a good reason for not using the canonical form?  If not,
I'd prefer to use it, although I won't object to what you did as well.

Also, perhaps it is worthwhile to spell out the language for each file
type.  Again, that's not a blocking comment.

Otherwise, okay with me.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]