This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: patch for testing purposes
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Michael <gdb-patches at cyberfiber dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 1 Jan 2010 07:35:36 +0400
- Subject: Re: patch for testing purposes
- References: <4B3B07F6.1020604@cyberfiber.org> <20091230081342.GD2788@adacore.com> <4B3B3AB1.5060106@cyberfiber.org> <20091230114518.GD548@adacore.com> <4B3C8D28.9070109@cyberfiber.org> <20091231115033.GL2788@adacore.com> <4B3D20F7.6010203@cyberfiber.org>
> i accidentally reversed the source and destination source files,
> here it is again.
Ah, ok! :).
I am sorry if I am repeating the same things, but you forgot to use
-up when generating the patch... Have you also had the chance to
read the CONTRIBUTE file? The ChangeLog entry is still missing too.
A little word of introduction to explain what you are trying to do
and why would have been helpful as well.
> < /* Print the status word STATUS. */
> <
> < static void
> < print_i387_status_word (unsigned int status, struct ui_file *file)
> ---
> > // print the status word
> > // updated 20091231 (development@codenamezero.org)
We do not use C++-style comments in the GDB code, because GDB is
supposed to be buildable with non-GCC compilers supporting ISO C90.
Also, the the "updated 20091231 (development@codenamezero.org)" is
superfluous and should go.
> < fprintf_filtered (file, "Status Word: %s",
> < hex_string_custom (status, 4));
> < fputs_filtered (" ", file);
> < fprintf_filtered (file, " %s", (status & 0x0001) ? "IE" : " ");
It looks like you changed the indentation of the code. This is not
correct. The indentation used in C for GNU projects is 2 spaces.
The change of indentation causes a lot of changes which are not
really changes, and prevents me from easily spot what the real
changes are - if there are any, I couldn't spot them.
--
Joel