This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Make sym_read routines handle separate debug files

On Dec 8, 2009, at 5:53 PM, Tom Tromey wrote:

> Tristan> @@ -947,8 +943,6 @@ symbol_file_add_with_addrs_or_offsets (bfd *abfd,
> [...]
> Tristan>    discard_cleanups (my_cleanups);
> 
> Tristan> -  if (addrs)
> Tristan> -    {
> Tristan> -      orig_addrs = copy_section_addr_info (addrs);
> Tristan> -      make_cleanup_free_section_addr_info (orig_addrs);
> Tristan> -    }
> 
> I think this function has a latent bug.  It calls
> discard_cleanups(my_cleanups), then makes a new cleanup which isn't
> assigned anywhere.  Then later it calls do_cleanups(my_cleanups).
> 
> Could you remove the do_cleanups?

Sure.  Indeed, it is not necessary anymore.

> This patch is ok with that change.  Thanks again.

Committed.  Thank you for the reviews.

Tristan.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]