This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: ppluzhnikov at google dot com (Paul Pluzhnikov)
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 15 Nov 2009 09:53:16 +0100
- Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
- References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com>
ppluzhnikov@google.com (Paul Pluzhnikov) writes:
> Index: cli/cli-cmds.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
> retrieving revision 1.93
> diff -u -p -u -r1.93 cli-cmds.c
> --- cli/cli-cmds.c 23 Oct 2009 00:49:33 -0000 1.93
> +++ cli/cli-cmds.c 13 Nov 2009 23:59:08 -0000
> @@ -1025,7 +1025,8 @@ disassemble_command (char *arg, int from
> /* FIXME: 'twould be nice to allow spaces in the expression for the first
> arg. Allow comma separater too? */
>
> - if (!(space_index = (char *) strchr (arg, ' ')))
> + space_index = skip_quoted (arg);
> + if (!(space_index = (char *) strchr (space_index, ' ')))
Looks like the comment is now obsolete?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."