This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't split executable paths with spaces in into multiple arguments


> In this particular case, though, I would probably have pushed back a
> bit, first because the patch is already fixing a previous "can't happen"
> assumption, and second because the correct code is really just 4 or 5
> lines.  (I thought for sure we would already have the quoting code lying
> around, but I grepped a little and couldn't find it.  It is odd that we
> have buildargv to split the argv but nothing to quote it.)

I understand.

Jon,

Would you mind enhancing your patch to handle all cases properly,
please?

Thanks,
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]