This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] replay bookmarks
On Thursday 05 November 2009 18:13:09, Michael Snyder wrote:
> Hui Zhu wrote:
> > I try this patch in i386 ubuntu. It works very good.
> >
> > Could you add some works in cmd help to talk about "begin" and "end"?
>
> Added, plus a few more _()'s, per comment from Eli.
Quick comments:
- any chance you could use packet_ok?
- '||'s at beginning of line, not at end.
- You should be bin2hex/hex2bin'ing the strings that are
being xfered over the wire.
--
Pedro Alves