This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] design question re: watchpoint target methods
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 29 Oct 2009 16:44:14 +0100
- Subject: Re: [RFC] design question re: watchpoint target methods
- References: <20091029145817.GO24340@adacore.com>
On Thu, 29 Oct 2009 15:58:17 +0100, Joel Brobecker wrote:
> enum stopped_by_watchpoint (*to_thread_stopped_by_watchpoint)
> (ptid_t ptid, CORE_ADDR *data_address_p);
>
> Actually, I think that all target_ops operations should take a struct
> target_ops parameter, even if not needed, at least for consistency, but
> also to facilitate transitions if this parameter ever becomes needed
> later on.
OK, I had some wrong assumptions, I see it fits more the targets abstractions,
I agree with adding it there.
Thanks,
Jan