This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA, 5 of 3] save/restore process record, part 5 (gcore change)
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>, Hui Zhu <teawater at gmail dot com>, Eli Zaretskii <eliz at gnu dot org>
- Date: Mon, 19 Oct 2009 10:18:16 -0600
- Subject: Re: [RFA, 5 of 3] save/restore process record, part 5 (gcore change)
- References: <4ADA9558.2010202@vmware.com>
- Reply-to: tromey at redhat dot com
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> +/* create_gcore_bfd -- helper for gcore_command (exported). */
Michael> +bfd *
Michael> +create_gcore_bfd (char *filename)
That comment is not very descriptive.
Michael> +/* write_gcore_file -- helper for gcore_command (exported). */
Michael> +
Michael> +void
Michael> +write_gcore_file (bfd *obfd)
Likewise.
Michael> Index: gcore.h
Michael> ===================================================================
Michael> RCS file: gcore.h
Michael> diff -N gcore.h
The gdb internals document says that headers should have include guards.
Tom