This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA, 2 of 3] save/restore process record, part 2 (core ops target)


> Date: Fri, 16 Oct 2009 18:24:43 -0700
> From: Michael Snyder <msnyder@vmware.com>
> 
> +  if (!tmp_to_resume)
> +    error (_("Process record can't get to_resume."));
> +  if (!tmp_to_wait)
> +    error (_("Process record can't get to_wait."));
> +  if (!tmp_to_store_registers)
> +    error (_("Process record can't get to_store_registers."));
> +  if (!tmp_to_insert_breakpoint)
> +    error (_("Process record can't get to_insert_breakpoint."));
> +  if (!tmp_to_remove_breakpoint)
> +    error (_("Process record can't get to_remove_breakpoint."));

Can we rephrase these to be more user-friendly?  As written, this text
is okay for debug printouts, but not for user-level error messages,
IMO.  (Yes, I know this text was in the old version, but still...)

> +  //if (strcmp (current_target.to_shortname, "record_core") == 0)
> +  //record_load ();

C++-style comments?

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]