This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][doc] PR python/10781
- From: Tom Tromey <tromey at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Phil Muldoon <pmuldoon at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 16 Oct 2009 12:07:01 -0600
- Subject: Re: [patch][doc] PR python/10781
- References: <4AD82247.3070503@redhat.com> <838wfbixtf.fsf@gnu.org>
- Reply-to: tromey at redhat dot com
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>> +Cast the @code{gdb.Value} to the type represented by @var{type}, and
Eli> ^^^
Eli> Please remove this "the".
Removing the "the" makes this read strangely.
gdb.Value is a class, the "the" indicates that it is an instance which is
cast.
>> +return a new @code{gdb.Value}. @var{type} must be a @code{gdb.Type}
>> +object.
Eli> If TYPE is an object, then it probably isn't a good idea to call it
Eli> TYPE. Why not OBJECT?
I think it is generally preferable to name parameters according to their
use. "object" is not specific enough.
Eli> Anyway, what does it mean "the type represented by TYPE"? How can a
Eli> type be "represented"? Did you perhaps mean "the type of TYPE"?
gdb.Type represents a type in the inferior.
"the type of TYPE" would be incorrect.
Tom