This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH/RFC] Signals & single-stepping
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Daniel Jacobowitz <drow at false dot org>, Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Date: Thu, 1 Oct 2009 15:51:18 +0100
- Subject: Re: [PATCH/RFC] Signals & single-stepping
- References: <200909301440.n8UEevPb017814@brahms.sibelius.xs4all.nl> <20090930162513.GA10304@caradoc.them.org>
On Wednesday 30 September 2009 17:25:13, Daniel Jacobowitz wrote:
> Your patch doesn't reintroduce the problem from the PR, and the new
> tests in interrupt.exp pass on x86_64-linux. ?I would really love
> someone else to volunteer to review it though - trap_expected confuses
> me horribly. ?I'd guess this change could lead to hitting (and
> displaying) the breakpoint at the current PC a second time, which is
> undesirable.
Yes, this messes with hit counts, reruns user breakpoint
commands, etc. Even some internal breakpoints don't like to
be re-hit for no reason. E.g., see linux-thread-db.c:check_event
"Cannot get thread event message".
I think the issue is that when stepping over a breakpoint,
for simplicity, GDB always removes all breakpoints. What if
we made it remove only breakpoints at stop_pc?
--
Pedro Alves