This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fix internal errors on 64-bit remote tarets
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Nathan Froyd <froydnj at codesourcery dot com>, pedro at codesourcery dot com
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 29 Sep 2009 16:48:45 -0700
- Subject: Re: [PATCH] fix internal errors on 64-bit remote tarets
- References: <20090713181027.GK11286@codesourcery.com>
[Pedro, Daniel, does this patch look correct to you. URL is:
http://www.sourceware.org/ml/gdb-patches/2009-07/msg00361.html.
Thanks!]
Sorry for taking so long to review this patch. You know that you have
remote protocol experts who can review & approve your patch, right? ;-)
> remote.exp fails on mips-sde-elf because remote.c tries to limit the
> minimum remote packet size to 20:
[...]
> which does indeed come out to 20. Except this is obviously wrong for
> 64-bit targets and is subtlely wrong for mips-sde-elf, because CORE_ADDR
> there is a 64-bit type. This patch bumps up the size unconditionally
> and adds an explanatory comment about how we get to the value we did.
> 2009-07-13 Nathan Froyd <froydnj@codesourcery.com>
>
> * gdb.base/remote.exp: Adjust messages.
The patch looks reasonable to me, except I don't think I know remote.c
well enough to always assess all effects of a given patch. Can you wait
for either Daniel or Pedro to confirm that this is OK before checking in?
--
Joel