This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix C++ typedefs parsing errors


>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> It looks fine to me, with one proviso.
Doug> Do we want the typedef-stripped type passed to write_exp_elt_type?
Doug> It kinda feels like we don't, but I don't honestly know.

I was wondering that too.

What would the failure mode look like?  I can't think of one.  It seems
to me that any actual definition would have to appear in the original
type, not solely in any typedef.

Also, if we do find some failure mode, it isn't like this patch can make
anything worse.  The current code will just error out early for any
typedef.

Therefore, this patch is ok.

thanks,
Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]