Re: [RFA] Fix "show convenience" test

[Paul Pluzhnikov <ppluzhnikov at google dot com>]

On Wed, Sep 16, 2009 at 10:08 AM, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Pedro Alves <pedro@codesourcery.com>
>> Date: Wed, 16 Sep 2009 14:16:22 +0100
>> Cc: gdb-patches@sourceware.org
>>
>> Hmm, I had already approved Paul's similar follow up patch at
>> <http://sourceware.org/ml/gdb-patches/2009-04/msg00105.html>.

I now see that you did. I lost that fact in the ensuing discussion of
testsuite failures :-(

>> I looks like it was waiting for a docs review.
>
> Ouch! sorry about that (binary attachments tend to have this effect on
> me ;-).

The attachment was actually text, just base64-encoded:
Content-Type: text/plain; charset=US-ASCII; name="gdb-convenience.20090406.txt"

Unfortunately, my attempts to convince gmail not to do that have failed :-(

>>  The variable @code{$_siginfo} is bound to extra signal information
>> -inspection (@pxref{extra signal information}).
>> +inspection (@pxref{extra signal information}). Note that @code{$_siginfo}
>> +could be empty. For example, it will be empty before you execute the
>> +@code{run} command.
>>  @end table
>
> A couple of comments:
>
>  . "the variable ... is bound to extra signal information inspection"
>    is awkward wording.  "How about "contains extra signal
>    information"?

Fixed.

>  . I don't understand the note about it being ``empty''?  What does
>    that mean, exactly, and why the example is talking about before
>    `run'?  I could understand that it's empty if no signals were
>    delivered yet, but what does `run' has to do with this?

Before the first 'run' is one rare case where the application has not yet
received any signals. I think this example could be simply removed
without much loss. Let me know if you'd like me to do that.

>
>  . Please leave two spaces between sentences, not one.

Sorry about that.  Fixed.


How does the attached patch look?

Here's the doc part, so you don't have to deal with base64:

Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.624
diff -u -p -u -r1.624 gdb.texinfo
--- doc/gdb.texinfo	15 Sep 2009 18:51:25 -0000	1.624
+++ doc/gdb.texinfo	17 Sep 2009 16:33:19 -0000
@@ -7819,8 +7819,10 @@ the program being debugged terminates.

 @item $_siginfo
 @vindex $_siginfo@r{, convenience variable}
-The variable @code{$_siginfo} is bound to extra signal information
-inspection (@pxref{extra signal information}).
+The variable @code{$_siginfo} contains extra signal information
+(@pxref{extra signal information}).  Note that @code{$_siginfo}
+could be empty, if the application has not yet received any signals.
+For example, it will be empty before you execute the @code{run} command.
 @end table

 On HP-UX systems, if you refer to a function or variable name that


Thanks,
-- 
Paul Pluzhnikov


testsuite/ChangeLog
2009-09-17  Paul Pluzhnikov  <ppluzhnikov@google.com>

	    * gdb.base/default.exp: Fix "show convenience".

doc/ChangeLog
2009-09-17  Paul Pluzhnikov  <ppluzhnikov@google.com>

	    * gdb.texinfo (convenince variables): Mention
	    $_siginfo could be empty.

Attachment: gdb-convenience.20090917.txt
Description: Text document