This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] reverse debugging tests
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 11 Sep 2009 16:29:03 -0600
- Subject: Re: [RFA] reverse debugging tests
- References: <4AAAB750.8000209@vmware.com>
- Reply-to: tromey at redhat dot com
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> Note, I've only done one of the several tests here --
Michael> if this change is approved, I'll change the others the same way.
Thanks for doing this.
Michael> So I've made two changes:
Michael> 1) In place of "if ![target_info exists gdb,can_reverse]"
Michael> substitute
Michael> +if [istarget "*linux*"] then {
Michael> + if { ![istarget "i?86-*linux*"] && ![istarget "amd64-*linux*"] } then {
Michael> + # test process record on i?86 and amd64 linux
Michael> + return;
Michael> + }
Michael> +}
I assume the old gdb,can_reverse and gdb,use_precord target settings no
longer make sense.
I would recommend putting each of these snippets into a function in
lib/gdb.exp. That way it is simpler to update them in the future.
Michael> + gdb_test "record" "" "Turn on process record"
Michael> + # FIXME: command ought to acknowledge, so we can test if it
Michael> succeeded.
This seems like a good idea.
Otherwise this looks fine to me.
Tom