This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix warnings using gcc-4.5 HEAD
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, mark dot kettenis at xs4all dot nl, gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 9 Sep 2009 18:48:21 -0700
- Subject: Re: [patch] Fix warnings using gcc-4.5 HEAD
- References: <20090711082502.GA18801@host0.dyn.jankratochvil.net> <200907110836.n6B8a4Yn015392@brahms.sibelius.xs4all.nl> <20090711083928.GA30826@host0.dyn.jankratochvil.net> <837hyfy3fv.fsf@gnu.org> <20090711175937.GB18892@host0.dyn.jankratochvil.net> <m38wi7t9z1.fsf@fleche.redhat.com> <20090908185119.GA10457@host0.dyn.jankratochvil.net>
> > I'd like Joel to comment on the Ada changes.
>
> Hi Joel, pinging for 7.0, this reply is to:
> http://sourceware.org/ml/gdb-patches/2009-07/msg00721.html
The Ada part seems fine. I'm left wondering if it really brings much
value to have this in a separate file, rather than added directly to
enum exp_opcode inside expression.h, especially since other languages
are now having visibility on these enumerates. But the the benefits
are not obvious either way to me, so let's not worry about this for now.
Do you want me to look at the rest of the patch as well, or did someone
(Tom?) look at that already?
--
Joel