This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c
- From: Hui Zhu <teawater at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Michael Snyder <msnyder at vmware dot com>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, freephp at gmail dot com
- Date: Wed, 9 Sep 2009 10:22:00 +0800
- Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c
- References: <daef60380908300615u40f59a38t7d2c2f2252c5924d@mail.gmail.com> <200908301356.n7UDuO4a006136@brahms.sibelius.xs4all.nl> <daef60380908300709i382261c9w6152a694dcdb5975@mail.gmail.com> <daef60380908300737k239bf7dcp6b4eb99c3b23b6f6@mail.gmail.com> <daef60380908310122w5ff65266wdb1a6667bdc8407f@mail.gmail.com> <4AA2CAFA.809@vmware.com> <20090905211541.GC30677@adacore.com> <daef60380909052115o1535a75k12874027350cf071@mail.gmail.com>
Hi guys,
What do you think about this patch?
Hui
On Sun, Sep 6, 2009 at 12:15, Hui Zhu<teawater@gmail.com> wrote:
> On Sun, Sep 6, 2009 at 05:15, Joel Brobecker<brobecker@adacore.com> wrote:
>>> I could suggest casting it to (unsigned int), but it wouldn't
>>> really make any difference, would it? ?Mark -- Jiang -- would
>>> that make you guys more comfortable?
>>
>> Short term, I'd rather see us read the syscall number as a signed
>> number since this is what record_linux_system_call expects. We can
>> decide whether to rationalize as a signed or unsigned as a separate
>> patch. I think Mark was OK with the patch I sent yesterday, except
>> that he said we should add a check against negative values.
>>
>> There is also a cast that is unnecessary in the error message.
>> Hui can use %s/paddress rather than %d/cast.
>>
>> --
>> Joel
>>
>
> Hi guys,
>
> I make a new patch according to your comment.
>
> Thanks,
> Hui
>
>
> 2009-09-06 ?Michael Snyder ?<msnyder@vmware.com>
> ? ? ? ? ? ?Joel Brobecker ?<brobecker@adacore.com>
> ? ? ? ? ? ?Hui Zhu ?<teawater@gmail.com>
>
> ? ? ? ?* i386-linux-tdep.c (i386_linux_intx80_sysenter_record): Change
> ? ? ? ?regcache_raw_read to regcache_raw_read_signed.
>
> Index: i386-linux-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-linux-tdep.c,v
> retrieving revision 1.66
> diff -u -p -r1.66 i386-linux-tdep.c
> --- i386-linux-tdep.c ? 10 Aug 2009 03:04:44 -0000 ? ? ?1.66
> +++ i386-linux-tdep.c ? 6 Sep 2009 02:12:15 -0000
> @@ -367,18 +367,19 @@ static int
> ?i386_linux_intx80_sysenter_record (struct regcache *regcache)
> ?{
> ? int ret;
> - ?uint32_t tmpu32;
> + ?LONGEST syscall;
>
> - ?regcache_raw_read (regcache, I386_EAX_REGNUM, (gdb_byte *) &tmpu32);
> + ?regcache_raw_read_signed (regcache, I386_EAX_REGNUM, &syscall);
>
> - ?if (tmpu32 > 499)
> + ?if (syscall < 0 || syscall > 499)
> ? ? {
> ? ? ? printf_unfiltered (_("Process record and replay target doesn't "
> - ? ? ? ? ? ? ? ? ? ? ? ? ? "support syscall number %u\n"), tmpu32);
> + ? ? ? ? ? ? ? ? ? ? ? ? ? "support syscall number %s\n"),
> + ? ? ? ? ? ? ? ? ? ? ? ?plongest (syscall));
> ? ? ? return -1;
> ? ? }
>
> - ?ret = record_linux_system_call (tmpu32, regcache,
> + ?ret = record_linux_system_call (syscall, regcache,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&i386_linux_record_tdep);
> ? if (ret)
> ? ? return ret;
>