This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] [ia64] ia64_memory_remove_breakpoint forgotten do_cleanups
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 8 Sep 2009 20:08:32 +0200
- Subject: [commit] [ia64] ia64_memory_remove_breakpoint forgotten do_cleanups
Hi,
one forgotten do_cleanups in a very unlikely code path.
No regression testing was made.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2009-09/msg00034.html
--- src/gdb/ChangeLog 2009/09/08 17:52:26 1.10850
+++ src/gdb/ChangeLog 2009/09/08 18:07:22 1.10851
@@ -1,5 +1,10 @@
2009-09-08 Jan Kratochvil <jan.kratochvil@redhat.com>
+ * ia64-tdep.c (ia64_memory_remove_breakpoint): Call do_cleanups
+ before a return.
+
+2009-09-08 Jan Kratochvil <jan.kratochvil@redhat.com>
+
* ia64-tdep.c (ia64_memory_insert_breakpoint)
(ia64_memory_remove_breakpoint): Return immediately if any of memory
reads fail. Do not combine the VAL values.
--- src/gdb/ia64-tdep.c 2009/09/08 17:52:27 1.198
+++ src/gdb/ia64-tdep.c 2009/09/08 18:07:23 1.199
@@ -725,6 +725,7 @@
warning (_("Cannot remove breakpoint at address %s, "
"no break instruction at such address."),
paddress (gdbarch, bp_tgt->placed_address));
+ do_cleanups (cleanup);
return -1;
}