This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add 'reverse' capability query to remote protocol (qSupported).
- From: Pedro Alves <pedro at codesourcery dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: Hui Zhu <teawater at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Jakob Engblom <jakob at virtutech dot com>, Greg Law <glaw at undo-software dot com>
- Date: Tue, 1 Sep 2009 16:52:28 +0100
- Subject: Re: [PATCH] Add 'reverse' capability query to remote protocol (qSupported).
- References: <4A9C2AD3.5070904@vmware.com> <daef60380908311943u447649edy3ed031b43adaea27@mail.gmail.com> <4A9C9CD2.7030207@vmware.com>
[replying to the updated patch itself]
> +
> + ? ? ?if (step &&
> +??????? ?remote_protocol_packets[PACKET_bs].support == PACKET_DISABLE)
> +???????error ("Remote reverse-step not supported.");
> + ? ? ?if (!step &&
> +??????? ?remote_protocol_packets[PACKET_bc].support == PACKET_DISABLE)
> +???????error ("Remote reverse-continue not supported.");
> +
'&&' at beginning of new line, not at end of previous line. The
error strings need wrapping in _() for i18n.
Don't forget docs and NEWS. :-)
--
Pedro Alves