This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: GDB MI Reverse Commands added [1 of 3]
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: Jakob Engblom <jakob at virtutech dot com>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 31 Aug 2009 14:01:58 -0600
- Subject: Re: GDB MI Reverse Commands added [1 of 3]
- References: <00ce01ca265a$ccb66ca0$662345e0$@com> <4A95E670.9040402@vmware.com>
- Reply-to: tromey at redhat dot com
Michael> Group, this patch seemed to have gotten a little munged in
Michael> email. I've taken the liberty of re-diffing it, to restore
Michael> white space context.
Thanks.
I have a few nits to pick.
Jakob> + if (argc > 0 && strcmp(argv[0], "--reverse") == 0)
Space before (".
There are a number of these.
Jakob> +/* continue in reverse direction:
Jakob> + XXX: code duplicated from reverse.c */
We're trying not to add new FIXME-type comments.
In this particular case I think it is ok to just drop the comment.
However, if you prefer, I think you could add a new exported
"make_cleanup_..." function in reverse.c.
Tom