Re: [RFA] Fix too many "no debugging symbols found" warnings.

[Doug Evans <dje at google dot com>]

On Mon, Jul 27, 2009 at 9:48 AM, Tom Tromey<tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> Maybe the thing to do is stick with the old format *if* using MI?
> Doug> If/when an MI command is added frontends can then just use that instead.
>
> I think that might be ok if we had a plan to remove the old code after
> some time. ?My concern is that we will otherwise end up with multiple
> layers of old formatting code.
>
> This particular function seems overdue for ui-out-ification.
> This would let us keep the old version for MI[12], and then properly
> evolve the output for future versions MI.
>
> Tom
>

Is this what you had in mind?

2009-08-24  Doug Evans  <dje@google.com>

        * NEWS: Add note on "info sharedlibrary".
        Remove note on "set print symbol-loading".
        * main.c (captured_main): Pass !batch for from_tty when calling
        symbol_file_add_main.
        * objfiles.h (objfile_has_partial_symbols): Declare.
        (objfile_has_full_symbols): Declare.
        * objfiles.c (objfile_has_partial_symbols): New function.
        (have_partial_symbols): Use it.
        (objfile_has_full_symbols): New function.
        (have_full_symbols): Use it.
        * solib.c: Include interps.h.
        (solib_read_symbols): Back out patch of 2008-07-10.
        Add test for info_verbose for symbol loading messages for
        consistency with symfile.c.
        (info_sharedlibrary_command): Handle optional parameter of regex of
        libraries to list.  Inform user of libraries without debugging info.
        Rewrite to use ui_out routines to format output.
        * symfile.c (print_symbol_loading): Delete.
        (symbol_file_add_with_addrs_or_offsets): Back out patch of 2008-07-10.
        Print "no debugging symbols found" only if from_tty || info_verbose;
        and only check file being loaded, not all files.
        (reread_symbols): Test file being loaded for whether it has symbols,
        not all files.
        (__initialize_symfile): Delete `set print symbol-loading'.
        * symfile.h (print_symbol_loading): Delete.

        * doc/gdb.texinfo: Delete `set print symbol-loading'.
        Add note on new optional regex arg to `info sharedlibrary'.

Attachment: gdb-090824-info-shared-1.patch.txt
Description: Text document