This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Simplify MI breakpoint setting
- From: Tom Tromey <tromey at redhat dot com>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 07 Aug 2009 11:45:44 -0600
- Subject: Re: Simplify MI breakpoint setting
- References: <200908011113.32939.vladimir@codesourcery.com>
- Reply-to: tromey at redhat dot com
>>>>> "Volodya" == Vladimir Prus <vladimir@codesourcery.com> writes:
Volodya> Further, set_breakpoint appears to be trivial and useless
Volodya> wrapper over break_command_really. This patch cleans that
Volodya> up. Are breakpoint.{c,h} changes OK?
I think the point of this is not to expose all the parameters of
break_command_really outside of breakpoint.c.
So, unless there is a problem with the current approach, I would prefer
not to change it.
In the alternative, if somebody does want to approve this, I would like
to recommend renaming break_command_really, as I don't think that is a
very good name for a public function.
Tom